flat assembler
Message board for the users of flat assembler.

Index > Macroinstructions > Fasmg > suggestion: minor adj. to calminstruction?.xcall?

Author
Thread Post new topic Reply to topic
fabbel



Joined: 30 Oct 2012
Posts: 83
fabbel 17 Jan 2024, 09:27
Hello Tomasz,

Regarding calminstruction?.xcall? (xcalm.inc),
I just realized it doesn't work with (symbolic) literal empty value,
which I think could be very easily adjusted by minor change to the code :
replacing line
Code:
match   <v>, v
    

with
Code:
 
match   <v?>, v
    


can you pls consider this small adj. in utility package ?

Thx
Post 17 Jan 2024, 09:27
View user's profile Send private message Reply with quote
Tomasz Grysztar



Joined: 16 Jun 2003
Posts: 8344
Location: Kraków, Poland
Tomasz Grysztar 17 Jan 2024, 16:40
Post 17 Jan 2024, 16:40
View user's profile Send private message Visit poster's website Reply with quote
fabbel



Joined: 30 Oct 2012
Posts: 83
fabbel 17 Jan 2024, 16:41
Many thx !!
Post 17 Jan 2024, 16:41
View user's profile Send private message Reply with quote
fabbel



Joined: 30 Oct 2012
Posts: 83
fabbel 29 Feb 2024, 13:18
Hihi

Another one :
since call allows argument to be "omitted when the definition of called instruction allows it",
I think this mandates another slight tweak in xcall implementation :
.... i suggest changing the below
Code:
        match   v=,arguments, arguments, <>
    

to
Code:
        match   v?=,arguments, arguments, <>
    


Tomasz, wud u pls consider ?


As a sidenote, i noticed u apparently did small change to CALM match - namely removing the restriction that bracket shud not appear in pattern - when using 3rd argument... but unless mistaken, I can't seem to find any note on this change anywhere ? Wud u pls elaborate ?

Many thx
Rgds
Post 29 Feb 2024, 13:18
View user's profile Send private message Reply with quote
Tomasz Grysztar



Joined: 16 Jun 2003
Posts: 8344
Location: Kraków, Poland
Tomasz Grysztar 29 Feb 2024, 13:57
fabbel wrote:
Tomasz, wud u pls consider ?
Yes, seems sensible.

fabbel wrote:
As a sidenote, i noticed u apparently did small change to CALM match - namely removing the restriction that bracket shud not appear in pattern - when using 3rd argument... but unless mistaken, I can't seem to find any note on this change anywhere ? Wud u pls elaborate ?
That restriction was a remnant of an earlier iteration of this feature, and it stayed there because when changing the design I was not sure whether it was still needed. But after revisiting it recently, I concluded that it was an artificial restriction, unnecessary code that could be removed to clean things up.
Post 29 Feb 2024, 13:57
View user's profile Send private message Visit poster's website Reply with quote
fabbel



Joined: 30 Oct 2012
Posts: 83
fabbel 29 Feb 2024, 13:58
tx !
Post 29 Feb 2024, 13:58
View user's profile Send private message Reply with quote
Display posts from previous:
Post new topic Reply to topic

Jump to:  


< Last Thread | Next Thread >
Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Copyright © 1999-2024, Tomasz Grysztar. Also on GitHub, YouTube.

Website powered by rwasa.