[flaw]checking if arg is empty

flat assembler
Message board for the users of flat assembler.

Index > Compiler Internals > [flaw]checking if arg is empty

Author

Thread

roxaz

Joined: 27 Jul 2008
Posts: 25

roxaz 27 Jul 2008, 11:39

im not even sure that we could call it a bug, so i marked thread as [flaw].
see how we must check if lSize is empty.

Code:

macro va_end ap*, lSize
{
    mov esp, ap
 if lSize eq
 else if
        add esp, lSize
   end if
      xor ap, ap
}

it would look much better if it worked like this:

Code:

macro va_end ap*, lSize
{
       mov esp, ap
 if lSize neq
           add esp, lSize
   end if
      xor ap, ap
}

i cant think of a reason why eq works and neq shouldnt work here...

27 Jul 2008, 11:39

Kenneth

Joined: 16 Nov 2005
Posts: 38
Location: United States of America

Kenneth 27 Jul 2008, 13:16

Code:

macro va_end ap*, lSize
{ 
        mov esp, ap 
        if ~ lSize eq
           add esp, lSize
        end if 
        xor ap, ap 
}

27 Jul 2008, 13:16

roxaz

Joined: 27 Jul 2008
Posts: 25

roxaz 27 Jul 2008, 17:11

heh.. yeah.. damn it

27 Jul 2008, 17:11

rCX

Joined: 29 Jul 2007
Posts: 172
Location: Maryland, USA

rCX 27 Jul 2008, 22:41

Code:

if lSize neq

I don't think neq or neqtype would be bad ideas for fasm considering that many things in asm use "n" to denote not. e.g. jne, loopne...

27 Jul 2008, 22:41

< Last Thread | Next Thread >

Forum Rules:

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum