Improving comments

Index > Macroinstructions > Improving comments

Author

Thread

pelaillo
Missing in inaction

Joined: 19 Jun 2003
Posts: 878
Location: Colombia

pelaillo 17 Nov 2003, 11:37

Privalov, I have the following suggestions for comments in fasm: Very Happy

1. Bypass comments on continuated lines. Ex.

Code:

invoke CreateWindowEx,NULL,_class,_title,\
  WS_OVERLAPPED+WS_VISIBLE+WS_CAPTION+WS_THICKFRAME+WS_SYSMENU,\
;WS_VISIBLE,\
  144,128,320,200,NULL,NULL,[wc.hInstance],NULL

2. Inline comments as C++ pair /* commented */. Ex.

Code:

invoke CreateWindowEx,NULL,_class,_title,\
  WS_OVERLAPPED+WS_VISIBLE;*+WS_CAPTION*;+WS_SYSMENU,\
  144,128,320,200,NULL,NULL,[wc.hInstance],NULL

17 Nov 2003, 11:37

pelaillo
Missing in inaction

Joined: 19 Jun 2003
Posts: 878
Location: Colombia

pelaillo 28 Nov 2003, 09:17

Hi Privalov,
There is a way to provide these enhancements in the ver. 1.50?

At least the first, because if I tell the fasm to continue a row, and the comments will be neglected, the logical consequence is that the continuation must be the next valid row. Doesn't it?

28 Nov 2003, 09:17

Tomasz Grysztar

Joined: 16 Jun 2003
Posts: 8356
Location: Kraków, Poland

Tomasz Grysztar 28 Nov 2003, 09:25

Why the row with a commend only would be "invalid"?
The logic of this operator is that it concatenates two lines into one, no matter what those line contain.
When you comment out a line in a chain, just put the backslash before the semicolon and all will be nice and logical.

28 Nov 2003, 09:25

pelaillo
Missing in inaction

Joined: 19 Jun 2003
Posts: 878
Location: Colombia

pelaillo 28 Nov 2003, 10:21

Sorry, I mean "empty", not "invalid".

The commented line is "empty" for the preprocessor, in other words it contains only CRLF or equivalent.

The concatenator operator issues an error if the line that follows is empty. A different measure for the same concept.

IMO, the backslash before the semicolon is unnecessary. Wink

Still, you have the last word, in case my arguments were not enough to convince you.

28 Nov 2003, 10:21

Tomasz Grysztar

Joined: 16 Jun 2003
Posts: 8356
Location: Kraków, Poland

Tomasz Grysztar 28 Nov 2003, 10:37

There is no error when the next line is emtpy - you've got an error only when there's no next line at all.

28 Nov 2003, 10:37

pelaillo
Missing in inaction

Joined: 19 Jun 2003
Posts: 878
Location: Colombia

pelaillo 28 Nov 2003, 11:15

Yes, you are right.

What about the second suggestion, please?

28 Nov 2003, 11:15

< Last Thread | Next Thread >

Forum Rules:

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum