Asm Newbie
Why is this an infinite loop?

code:

format PE CONSOLE
entry start
include 'c:\cc\crenshawbasic\testb\fasmw167\include\win32ax.inc'

section '.data' data readable
msg db 'HELLO'

section '.code' code readable executable
pushad
start:
mov ecx,0
loop1:
cinvoke printf,msg
add ecx,1
cmp ecx,10
jnz loop1
invoke ExitProcess,0
popad
section '.idata' import data readable writeable
library kernel32,'kernel32.dll',crtdll,'crtdll.dll'
import kernel32,ExitProcess,'ExitProcess'
import crtdll,printf,'printf'

Thanks!

try pushing and poping ecx before and after the printf accordingly.

Try using ebx, esi, ebp or edi instead of ecx. The 4 registers I mentioned there are preserved by the printf function whereas all the other registers (eax, ecx and edx) should be assumed to be clobbered.

I'd also like to note that your string isn't terminated (you seem to be using 10, but printf uses 0). That means it'll start printing the code of your Exe. Also, since each letter isn't null terminated, if you don't print out your code, the output would look a bit like this...

Thanks guys,

I did use ebx and that is OK.
But does it mean that I need to use ebx or push and pop ecx for all
the crtdll functions?
Are there other dll's who give problems with ebx or others that You
know of?

And Yes I got the HELLOHELLO.....
but no problem as I posted only because of the endless loop problem.

But never the less,

Thanks
Ren

For every API function you call actually, it is the way stdcall and cdecl calling convention works. Only EBP, EBX, ESI and EDI are preserved. On stdcall ESP returns with the value prior to the first argument push and cdecl returns ESP with the same value it had before executing the CALL instruction.

Thanks, that's what I needed!

Ran