lock cmp eax, ebx
    

as I have several times used lock incorrectly and had to waste time debugging to locate the problem

The above code you post is an error on some processors and okay on others.

What processor is that instruction valid on?

You probably mean Cyrix. I really don't think that fasm should support such obsolete, manufacturer-specific instructions. Additionally, there are some Cyrix-specific instructions and fasm doesn't support them at all.

most of the warnings were totally useless crap that only served to make my screen fill up with text

Many times for open source code the author would need to state something like "ignore the warnings you get when compiling", to me that always seemed very silly.

fasm doesn't generate any warnings. This is a good thing. Warnings are too troublesome and for the most part useless.

The above code you post is an error on some processors and okay on others.

If fasm were to have warnings then it would also need to know about all the different types of CPU's on the market both now and in the past.

Basically, if your code has an error like the above then it is you that must fix it, not the assembler. That is why we must test our programs an then test again, after that we need to test once more.

lazer1 wrote:

as I have several times used lock incorrectly and had to waste time debugging to locate the problem

Why must you waste time. If the CPU gives a GPF then it is trivial to get the fault address and see the lock code there.

Also, unless you are writing some SMP code (maybe a SMP OS?) then there is generally no need to use lock at all.

not really, I am just asking that fasm conforms to the Intel Vol 3 documentation,

that is THE definitive document on 32 bit x86 functionality,

unless you know of a free long mode disassembler,

macro lock instr_dest, src
{
common
local aux

  lock instr_dest, src

  match instr dest, instr_dest
  \{
    aux equ BAD_INSTR

    irps ins, adc add and btc btr bts cmpxchg cmpxchg8b cmpxchg16b dec inc neg not or sbb sub xadd xchg xor
    \\{
      match =instr, ins\\\{aux equ OK_INSTR\\\}
    \\}

    match =BAD_INSTR, aux
    \\{
      display "ERROR: Invalid instruction for lock prefix", 13, 10
      ; NOTE: Things like "lock rep xor [ebx], eax" are not allowed even though REP doesn't produce any exception
      err
    \\}

    if ~dest eqtype [0]
      display "ERROR: Using lock prefix with no memory destination", 13, 10
      err
    end if
  \}
}    

Quote:

not really, I am just asking that fasm conforms to the Intel Vol 3 documentation,

that is THE definitive document on 32 bit x86 functionality,

OK, time to remove 3DNow from fasm then

Quote:

unless you know of a free long mode disassembler,

http://board.flatassembler.net/topic.php?t=5045

Here a macro for you

Code:

macro lock instr_dest, src
{
common
local aux

  lock instr_dest, src

  match instr dest, instr_dest
  \{
    aux equ BAD_INSTR

    irps ins, adc add and btc btr bts cmpxchg cmpxchg8b cmpxchg16b dec inc neg not or sbb sub xadd xchg xor
    \\{
      match =instr, ins\\\{aux equ OK_INSTR\\\}
    \\}

    match =BAD_INSTR, aux
    \\{
      display "ERROR: Invalid instruction for lock prefix", 13, 10
      ; NOTE: Things like "lock rep xor [ebx], eax" are not allowed even though REP doesn't produce any exception
      err
    \\}

    if ~dest eqtype [0]
      display "ERROR: Using lock prefix with no memory destination", 13, 10
      err
    end if
  \}
}    

http://board.flatassembler.net/topic.php?p=55710#55710
But since it's your own OS it will not work, sorry I though you was doing Windows/Linux 64-bit multi-threaded code.

I never tried it but some people here did and seems to work, but, it is a debugger, you need Win64 or Linux64 and a PE64 or ELF64 respectively. Look at Madis's FDBG screenshot here http://www.tud.ttu.ee/~t060429/Up/Optimal.png

I'm "studying" maths now for the exam I have tomorrow. I'll try after the exam to produce some listing generator using macros, I think it should be possible using again irps however I can't do it in a couple of minutes because there are lot of instructions plus the assembler directives that produce some output.

BTW, after using the lock macro you are still experiencing faults? Note that maybe it's something else then.

   use16
   lock bts dword [ fs : ecx ], 0
    

ERROR: Using lock prefix with no memory destination
lock.asm [8]:
        lock bts dword [ fs : ecx ], 0
lock_macro.txt [26] lock [24]:
      err
error: illegal instruction.