flat assembler
Message board for the users of flat assembler.

Index > Compiler Internals > source commentary request

Author
Thread Post new topic Reply to topic
arafel



Joined: 29 Aug 2006
Posts: 131
Location: Jerusalem, Israel
arafel
Tomasz,
Is there any chance you will add comments, even if only sparse, for the future fasm updates?
Currently there is no single line of commentary and the code is far from modular which makes it near to impossible do decipher without hairs being pulled out. I know this is very boring task to do and probably not that significant aspect for a person who actually wrote the code, but such lack of commentary makes it rather hard to do any 3rd party modifications.
Post 05 Mar 2007, 02:14
View user's profile Send private message Reply with quote
DOS386



Joined: 08 Dec 2006
Posts: 1901
DOS386
Quote:
such lack of commentary makes it rather hard to do any 3rd party modifications


Intention ?

Quote:
Currently there is no single line of commentary


There ARE comments .. but rare ...

Quote:
code is far from modular which makes it near to impossible do decipher without hairs being pulled out


I like the code (OK, there could be more comments). It is MUCH
better than some typical "easily maintainable" "C++"-code Laughing

_________________
Bug Nr.: 12345

Title: Hello World program compiles to 100 KB !!!

Status: Closed: NOT a Bug
Post 05 Mar 2007, 09:30
View user's profile Send private message Reply with quote
Raedwulf



Joined: 13 Jul 2005
Posts: 375
Location: United Kingdom
Raedwulf
The comments are in the label names Wink.
It took me a while, but I find reading FASMW really easy now. Very Happy.
I do not think the FASM is too far off, though its a bit 'lower-level' asm then FASMW.
Post 05 Mar 2007, 11:15
View user's profile Send private message MSN Messenger Reply with quote
arafel



Joined: 29 Aug 2006
Posts: 131
Location: Jerusalem, Israel
arafel
NTOSKRNL_VXE wrote:
Intention ?

as in why someone would like to make modifications?
Raedwulf wrote:
The comments are in the label names

Indeed. But since fasm code looks to be optimized more for performance than readability/maintenance an occasional "; here we setup blablabla for blabla" or "; save pointer to blabla for blablabla" could be nice.
Quote:
It took me a while,

That's exactly what I am trying to avoid Smile

_________________
lscr::winstuff
Post 06 Mar 2007, 20:16
View user's profile Send private message Reply with quote
Raedwulf



Joined: 13 Jul 2005
Posts: 375
Location: United Kingdom
Raedwulf
The while only lasted like 1 day Very Happy.
Post 07 Mar 2007, 13:58
View user's profile Send private message MSN Messenger Reply with quote
Display posts from previous:
Post new topic Reply to topic

Jump to:  


< Last Thread | Next Thread >
Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Copyright © 1999-2020, Tomasz Grysztar. Also on YouTube, Twitter.

Website powered by rwasa.