odd error

Index > Windows > odd error

Author

Thread

blacky

Joined: 06 Apr 2006
Posts: 32
Location: JA

blacky 04 May 2006, 14:31

I dont understand why im getting an error here..

Code:

section '.idata' import readable writeable

        library kernel32,'KERNEL32.DLL', user32,'USER32.DLL'
        include 'apia/kernel32.inc'
        include 'apia/user32.inc'

Loader.asm [75]:
library kernel32,'KERNEL32.DLL', user32,'USER32.DLL'
error: illegal instruction.

Whats wrong?

04 May 2006, 14:31

vid
Verbosity in development

Joined: 05 Sep 2003
Posts: 7105
Location: Slovakia

vid 04 May 2006, 14:41

you need to

Code:

include '%fasminc%/MACRO/import32.inc'

"library" is not directive, it's just macro defined in this file

04 May 2006, 14:41

blacky

Joined: 06 Apr 2006
Posts: 32
Location: JA

blacky 04 May 2006, 15:53

IS theres omething about using 'call' and invoke that makes using the words OFFSET or ADDR not work?

why do i get undefined symbol for this:

Code:

         push offset pinfo
         push offset sinfo
         push 0
         push 0
         push CREATE_NEW_CONSOLE
         push 0
         push 0
         push 0
         push offset wmoname
         push 0
         call [CreateProcess]

pinfo PROCESS_INFORMATION
sinfo STARTUPINFO are defined in .data section.

And it also wont let me do things like
push pinfo.dwProcessID

04 May 2006, 15:53

f0dder

Joined: 19 Feb 2004
Posts: 3175
Location: Denmark

f0dder 04 May 2006, 16:26

blacky, "offset" is a relic from MASM. You should just do "push pinfo" and "push sinfo" to store the addresses of those variables.

When accessing memory, you need "indirection brackets" - like "push [pinfo.dwProcessID]".

Also, why are you using manual pushpushpushpushcall instead of invoke? Smile

04 May 2006, 16:26

blacky

Joined: 06 Apr 2006
Posts: 32
Location: JA

blacky 04 May 2006, 17:12

yea , f0dder thanks i just took a look at a very good asm reference and i used the formal way. (push pinfo)

I dont know why but the push push call just makes sense to me and it helps me understand how 'real' assembly works, i use invoke whenever my fingers feel like typing it heh..
thx.

04 May 2006, 17:12

vid
Verbosity in development

Joined: 05 Sep 2003
Posts: 7105
Location: Slovakia

vid 04 May 2006, 17:58

f0dder wrote:

Also, why are you using manual pushpushpushpushcall instead of invoke?

you can comment code better then

04 May 2006, 17:58

blacky

Joined: 06 Apr 2006
Posts: 32
Location: JA

blacky 04 May 2006, 18:13

so stupid i just had to erase it..

Last edited by blacky on 04 May 2006, 18:29; edited 1 time in total

04 May 2006, 18:13

f0dder

Joined: 19 Feb 2004
Posts: 3175
Location: Denmark

f0dder 04 May 2006, 18:19

vid wrote:

f0dder wrote:
Also, why are you using manual pushpushpushpushcall instead of invoke?

you can comment code better then

Do you really need a comment for each parameter passed to a function? :-s

Blacky, MB_OK is a symbolic constant for 0 - so you *could* just "push 0", but you *should* "push MB_OK". Anyway, you're forgetting the 'hwnd' parameter to MessageBox, use 0.

_________________

- carpe noctem

04 May 2006, 18:19

blacky

Joined: 06 Apr 2006
Posts: 32
Location: JA

blacky 04 May 2006, 18:28

yea just noticed.. dumbest mistake ive done..how careless.

04 May 2006, 18:28

okasvi

Joined: 18 Aug 2005
Posts: 382
Location: Finland

okasvi 04 May 2006, 19:59

vid wrote:

f0dder wrote:
Also, why are you using manual pushpushpushpushcall instead of invoke?

you can comment code better then

yep, it helps, sometimes when using api not used to and pushing temp vars i put comment after it what it is supposed to be, and when i was starting with fasm it helped me to see what i do and where in ollydbg easier...

_________________
When We Ride On Our Enemies
support reverse smileys |:

04 May 2006, 19:59

Tomasz Grysztar

Joined: 16 Jun 2003
Posts: 8351
Location: Kraków, Poland

Tomasz Grysztar 05 May 2006, 03:01

You can put a comment next to each parameter with "invoke", too (just split it to multiple lines).

05 May 2006, 03:01

vid
Verbosity in development

Joined: 05 Sep 2003
Posts: 7105
Location: Slovakia

vid 05 May 2006, 08:34

tomasz: of course, but indenting makes problem then. it just "looks bad"

05 May 2006, 08:34

RedGhost

Joined: 18 May 2005
Posts: 443
Location: BC, Canada

RedGhost 06 May 2006, 03:57

i use push/call not invoke aswell, and it does allower a cleaner syntax for commenting specific parameters

06 May 2006, 03:57

< Last Thread | Next Thread >

Forum Rules:

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum