Interesting idea for macro repetition

Index > Macroinstructions > Interesting idea for macro repetition

Goto page Previous 1, 2, 3

Author

Thread

Tomasz Grysztar

Joined: 16 Jun 2003
Posts: 7797
Location: Kraków, Poland

Tomasz Grysztar

First, this would require using "fix" where it's not needed currently - breaking backward compatibility. Also what vid proposed allows to avoid fixes at all in all types of such definitions.

Second, it would cause even more problems with symbols like "forward" - if they were affected by "current level" of braces, you wouldn't be able to use the higher level "forward" for the contents of inner macro.

With the backlashes solution you just write "\forward", "\\forward" etc. for different levels.

11 May 2005, 11:43

JohnFound

Joined: 16 Jun 2003
Posts: 3502
Location: Bulgaria

JohnFound

Privalov wrote:

With the backlashes solution you just write "\forward", "\\forward" etc. for different levels.

Well, this approach is really good enough for everything. And even more, it improves the readability. Combined with preprocessor repetition and conditional preprocessing, it will simplify complex macroses a lot.

Regards

11 May 2005, 12:12

asmdemon

Joined: 18 Jan 2004
Posts: 97
Location: Virginia Beach, VA

asmdemon

Privalov wrote:

I'm attaching the modified preprocessor module that has it.

Will you include these in the next release? AND/OR the fasm documentation?

_________________
It is better to be on the right side of the devil than in his path.

11 May 2005, 13:28

pelaillo
Missing in inaction

Joined: 19 Jun 2003
Posts: 878
Location: Colombia

pelaillo

Yes, better solution. Backlashes provide an immediate visual indication of the level concerned.

11 May 2005, 13:35

vid
Verbosity in development

Joined: 05 Sep 2003
Posts: 7105
Location: Slovakia

vid

great work, i love it

12 May 2005, 17:30

MCD

Joined: 21 Aug 2004
Posts: 604
Location: Germany

MCD

Great, but there is only 1 question remaining to me:

Will this just remove all of the

Code:

_% %_ _local _common _forward _reverse

crap we used to use a lot in fasm? You now, they will become pretty superfluous, because stuff like this:

Code:

macro SomeMacro
{

 macro Inner
 _%
  SomeStuff
 %_

 SomeStuff
}

_% fix {
%_ fix }

would become

Code:

macro SomeMacro
{

 macro Inner
 {
  SomeStuff
 /}

 SomeStuff
}

_________________
MCD - the inevitable return of the Mad Computer Doggy

-||__/
.|+-~
.|| ||

24 May 2005, 11:29

Tomasz Grysztar

Joined: 16 Jun 2003
Posts: 7797
Location: Kraków, Poland

Tomasz Grysztar

Yes, those fixes are already removed from the standard Win32 includes, replaced with the new solution.

24 May 2005, 12:56

revolution
When all else fails, read the source

Joined: 24 Aug 2004
Posts: 17669
Location: In your JS exploiting you and your system

revolution

I tried the example from the documentation but get "Error: unexpected characters." when assembling.

Code:

 rept 5 { in al,dx }

It can be made to assemble with the addition of a variable name

Code:

 rept 5 v { in al,dx }

25 May 2005, 06:58

Tomasz Grysztar

Joined: 16 Jun 2003
Posts: 7797
Location: Kraków, Poland

Tomasz Grysztar

My stupid mistake, fixed now.

25 May 2005, 08:28

revolution
When all else fails, read the source

Joined: 24 Aug 2004
Posts: 17669
Location: In your JS exploiting you and your system

revolution

The code below causes FASM 1.61.7 to crash.

Code:

rept 1 {macro foo [arg] \{ \common nop \} }
foo test

The same thing, but with one extra line feed is okay.

Code:

rept 1 {macro foo [arg] \{
\common nop \} }
foo test

26 May 2005, 03:07

Tomasz Grysztar

Joined: 16 Jun 2003
Posts: 7797
Location: Kraków, Poland

Tomasz Grysztar

Another fix... I must have been sleepy when writing this...

26 May 2005, 07:06

Goto page Previous 1, 2, 3

< Last Thread | Next Thread >

Forum Rules:

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum