:/ Grr.. irritating... txt file not accepted.

StrLen:       ; proc StrLen [hString]
     mov     eax,[esp+4]             ; mov eax,[hString]
 stdcall StrPtr,eax
 .scan:
   cmp     byte[eax],0
 lea     ecx,[eax+1]
 jnz     .scan
       sub     eax, [esp+4]
        dec     eax                     ; return value in eax
       ret     4
    

StrLen:    ; proc StrLen [hString]
        push    ebx      ; esp = esp-4
        mov     eax,[esp+4+4]      ; mov eax,[hString]
        stdcall StrPtr,eax
        mov     ebx,eax
  .scan:
        cmp     byte[eax],0
        lea     eax,[eax+1]
        jnz     .scan
        sub     eax,ebx
        dec     eax         ; return value in eax
        pop     ebx
        ret     4    

        push    dword [esp+4+4]
        call    StrPtr     

        stdcall StrPtr,[esp+4+4]    

       stdcall NumToStr, 255, ntsHex
      stdcall StrInsert,hString,eax,8    

John,
When coding a routine that inserts one string into another I realized that I could make NumToStr to create new string only, and inserting number into the string could be done this way:

Code:

       stdcall NumToStr, 255, ntsHex
      stdcall StrInsert,hString,eax,8    

if hString="total 0x bytes" after that code it will be "total 0xFF bytes"

IMO this solution is more flexible, as you don't have to care about space for numbers when creating strings. Also, it will make NumToStr much simpler...

What do you think?

roticv: your routines doesn't know about string handles. Can you fix it?

;***********************************************
; NumToStrF:
;   Converts signed integer value to string.
; NumToStrUF:
;   Converts unsigned integer value to string.
;
; EDI - pointer to string buffer
; EAX - Number to convert
; ECX - radix from 2 to $ff
; EBX - length of the number in chars
;
; Note: Don't use 1 as radix.
;************************************

if used NumToStrF

NumToStrF:

        test    eax,eax
        jns     NumToStrUF
        neg     eax
        mov     byte [edi],'-'

        push    ebx

        dec     ebx
        add     edi,ebx
        jmp     .loopc

end if

if used NumToStrUF

NumToStrUF:
        push    ebx
        add     edi, ebx
        dec     edi

.loopc:
        xor     edx,edx
        div     ecx

        xchg    al,dl
        cmp     al,$0a
        sbb     al,$69
        das

        mov     [edi],al
        dec     edi
        xchg    al,dl


        dec     ebx
        jnz     .loopc

        pop     ebx
        ret

end if
    

BTW, We have to use "if used" statements to make only used subroutines to be included in the program. I will try include this approach in proc macro to make it more smart to avoid using of enter/leave when there is no local variables.

NumToStr is not complete. Please make something.

macro proc name,[arg]                   ; define procedure
 { common
    if used name
      name:
      virtual at ebp+8
      if ~ arg eq
     forward
       local ..arg
       ..arg dd ?
       arg equ ..arg
     common
       end if
       ..ret = $ - (ebp+8)
      end virtual
      local ..dynamic_data,..dynamic_size
      dynamic_data equ ..dynamic_data
      dynamic_size equ ..dynamic_size
      virtual at ebp - dynamic_size
       dynamic_data: }

macro enter                             ; begin procedure instructions
 { rb (4 - ($-dynamic_data) and 11b) and 11b
   dynamic_size = $ - dynamic_data
   end virtual

   if dynamic_size = 0
     push ebp                     ; smaller is dynamic_size = 0
     mov  ebp, esp
   else
     enter dynamic_size,0
   end if
 }

macro return                            ; return from procedure
 {
     leave
     ret ..ret
   else
     display 'Procedure skipped',$0d, $0a
   end if
 }    

;**********************************************************************************
; StrPos returns a pointer to the first occurence of a pattern string
;   in another string
; Arguments:
;   hPattern - 'pattern' string
;   hString -  string to search
; Returns: a pointer to the pattern string in source , or NULL if pattern string
; doesn't occur in the string to search
;**********************************************************************************    

Hi, scientica.
I am glad that you have an inspiration.

StrPos is search in string:

substring:
    mov eax,[esp+4]      ; first parameter
    stdcall StrPtr,eax
    add eax,[esp+8]       ; second parameter
    ret 8