repeat and "already defined"

Index > Macroinstructions > repeat and "already defined"

Author

Thread

omega_red

Joined: 13 Mar 2004
Posts: 19
Location: Poland

omega_red 28 Nov 2004, 18:47

I have a macro:

Code:

macro timing INNER_LOOP_COUNT
{
...
@@:
   times INNER_LOOP_COUNT          add     eax, ebx
    loop    @b
...
}

Then, in main program I'm using this:

Code:

repeat 16
   timing %
end repeat

to make 16 blocks with incrementing INNER_LOOP_COUNT. However, it gives me an error:

Code:

C:\asm\test.asm [51]:
    timing %
C:\asm\test.asm [17] timing [9]:
@@:
error: symbol already defined.

Well, @@ is supposed to be anonymous label? How to do it properly without manually 'unrolling' repeat construction?

_________________
Vulnerant omnes, ultima necat

28 Nov 2004, 18:47

crc

Joined: 21 Jun 2003
Posts: 637
Location: Penndel, PA [USA]

crc 28 Nov 2004, 20:08

Code:

macro timing INNER_LOOP_COUNT
{
...
local a     ; a is a local label
label a    ; this is where it's used 
        times INNER_LOOP_COUNT          add     eax, ebx
        loop    a    ; loop to a
...
}

Try that and see if it works. @@: probably doesn't work within macros.

28 Nov 2004, 20:08

omega_red

Joined: 13 Mar 2004
Posts: 19
Location: Poland

omega_red 28 Nov 2004, 21:24

Code:

label outer_loop
error: symbol already defined.

Weird...

28 Nov 2004, 21:24

crc

Joined: 21 Jun 2003
Posts: 637
Location: Penndel, PA [USA]

crc 28 Nov 2004, 21:58

Maybe doing this:

Code:

macro timing INNER_LOOP_COUNT
{
...
local a     ; a is a local label
a:           ; this is where it's used 
        times INNER_LOOP_COUNT          add     eax, ebx
        loop    a    ; loop to a
...
}

would work?

28 Nov 2004, 21:58

omega_red

Joined: 13 Mar 2004
Posts: 19
Location: Poland

omega_red 29 Nov 2004, 01:32

I've tried it earlier - with the same result..

29 Nov 2004, 01:32

crc

Joined: 21 Jun 2003
Posts: 637
Location: Penndel, PA [USA]

crc 29 Nov 2004, 02:09

Code:

macro timing INNER_LOOP_COUNT
{
local a 
a:
        times INNER_LOOP_COUNT          add     eax, ebx
        loop    a
}


main:
  timing 22
  timing 23
ret

That compiles without fail for me. Can you paste more of the code that's causing the problem?

29 Nov 2004, 02:09

omega_red

Joined: 13 Mar 2004
Posts: 19
Location: Poland

omega_red 29 Nov 2004, 11:03

Yeah, thats exactly ok. But this fail:

Code:

main: 
repeat 2
  timing %
end repeat
ret

29 Nov 2004, 11:03

crc

Joined: 21 Jun 2003
Posts: 637
Location: Penndel, PA [USA]

crc 29 Nov 2004, 11:06

What does the % imply?

29 Nov 2004, 11:06

omega_red

Joined: 13 Mar 2004
Posts: 19
Location: Poland

omega_red 29 Nov 2004, 13:36

Quote:

Second is "%", which is the number of current repeat in parts of code
that are repeated using some special directives (see 2.2).

My goal is to shorten

Code:

 timing  1
   timing  2
   timing  3
   timing  4
   timing  5
   timing  6
   timing  7
   timing  8
   ...

with repeat construction. Maybe there is another way to do it?

_________________
Vulnerant omnes, ultima necat

29 Nov 2004, 13:36

vid
Verbosity in development

Joined: 05 Sep 2003
Posts: 7105
Location: Slovakia

vid 29 Nov 2004, 15:02

try this:

Code:

local here
here = $          ;not "here:", because that way it cannot be redefined
times SOME_CONSTANT add eax,ebx
loop here

If it won't work, than you can hardcode lenght of jump:

Code:

times SOME_CONSTANT add eax,ebx
loop $-(SOMECONSTANT*2) ;i quess size of "add eax,ebx" is 2, easy to hceck

29 Nov 2004, 15:02

< Last Thread | Next Thread >

Forum Rules:

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum