Here's the first pre-release of the new FASMW, with almost completely rewritten AsmEdit control (it will become AsmEdit 2.0 when it's finished, but I even haven't decided for the final set of features for that version). All operations on text were rewritten from scratch, and now they need testing.

I have already tested it with 25 MB dump of this board's SQL database (318098 lines, 31041 characters in the longest line) and it worked fine.

Attachment removed - not it's official release

Hi Tomasz.
Good work.
At first sight, one little misbehaviour: The right mouse click, opening popup menu, have to move the caret also to the place of the click. This is important in case you choose from the menu some functions that modifies the text - like paste for example.

Regards.

But this way you would cancel the selection, while you would want to select "Cut" or "Delete" from that menu.

Yea, I know, but AFAIR, I fixed this problem somehow in Fresh modified version of AsmEdit. You can check the sources - the main idea was, that it moves caret, only if there is no selected text.

Isn't it too confusing? When caret/selection is somewhere out of window, the result of such click would be unpredictable.

Well, 'paste', where the text apears somewhere else is confusing too. There should be proper behaviour that to satisfy all problems. btw: IMO, if the selection is out of the screem, it will be absolutely OK if right click cancels the selection, because in the other case, there may be massive, obscured, lost of text.

Privalov, would it be difficult to implement bookmark support in FASMW? I see you are using constants for segment length, and header length, etc. So it should be possible to stick a bookmarked flag in the header?
Support for bookmarks would be greatly appreciated.

IMHO,
When there is a selection and:
- right-click on editor:
- asmedit context menu pops up.
- selection holds unless cut/delete is selected.
- caret remains at position before click.

- right-click outside editor:
- other-object context menu pops up.
- selection holds as has nothing to do with menu popped-up.
- caret remains at position before click.

comrade: yes, this was the reason for defining those constants, it's just that I want to reimplement all the previous AsmEdit's functionality before adding really new features.

Please test the stability of the editor, it's the most important thing right now.

I think that it may be done in this way (like it's done AFAIK everywhere):
then user right-clicks on editor window, you must check if it clicked inside the selection or outside it. If inside then selection must remain, otherwise it disappears. Anyway cursor moves to the click location.

Errors I get:
1. "No enough memory to comlete operation" - then I run it and type 1st character. Clicking OK and further writing without problems.
2. Selectiong some text (MORE THEN ONE LINE), pressing some character, text replaces, selection stays visible. Do nothing with this, just pressing another key results in "Instruction ... "0x0040c503" ... "0x00000000" . ... "written".". Line 3852, asmedit.inc:

After some though, I think the proper behaviour is that suggested by mike.dld with one little difference:

On WM_RBUTTONDOWN:
1. Secure selection OFF
1.1. If the mouse cursor is inside current selection: Opens popup menu without moving the caret from its current position (end of selection).
1.2. If the mouse cursor is outside the current selection: Moves the caret at mouse cursor position (thus removing selection) and then opens the popup menu.

2. Secure selection ON - At first in this case, IMHO, the caret have to have ability to be moved without canceling selection - i.e. the begin and end position of the selection have to be independent from the caret position.
2.1. in this case every right click have to move the caret at the position of the mouse cursor, the curent selection (if any) should remain unchanged.

Note: maybe it worths to not keep fixed popup menu handle, but to obtain the handle through notification message - if the user want to have context dependent popup menues for different cases.

Bug report: Maybe this is some relicts from the old version, but search function gives "Not enough memory" error window (without crashing fasmw).

Regards.

mike.dld: Thanks, I have fixed the second issue, but I don't understand how did you come with the first one. The "not enough memory" message is issued when you try to do search operation, as it is not implemented yet (see the first post) and I have made it issue "out of memory" notification instead. Was it something else?

No, I just ran fasmw and pressed 'a' (or some other char) in the editor. The message appeared. I've choosen OK and after that no such things were occured.

Are you able to reproduce it? What system are you using?

Yes, message appears every time I run fasm and typing first char. I'm using Windows XP.

This would be "Persistent blocks" (as in DN), not "Secure selection" option. Might get implemented if I have time.
As for the right click, I prefer to stay with the pellailo's (in fact current) option.

OK, thank to Mike's cooperation I have fixed that "not enough memory" issue.

Your choice. Good it will be open source.

Several issues from asmedit.txt file:

1. AEM_SETPOS description still mentions position 257 as maximum (have to be -1).
2. AEM_GETWORDATCARET - now the maximal size of the word is not 256 characters, so we need AEM_GETWORDLENGTH of something.
Note, that for Fresh I needed a little bit different behaviour:

I needed this behaviour, because of code completition function that have to replace current word. Of course it is possible to make this through different message: AEM_GETWORDPOS for example.

3. Syntax highlighter: I though, whether it will be better not to keep tables with colors, but to make lpColors to be array of dwords and to leave syntax procedure to put inside colors instead of indexes to the palette.
At least this will make possible to have one common color handling for all ASMEdIT windows in the program without need to set the color table for every window separately.

4. AEM_SETLINE - we have AEM_GETLINE, why not to have AEM_SETLINE also? Also AEM_INSERTLINE, AEM_DELETELINE can be useful, although this functions can be emulated using EM_REPLACESEL

Some wishes, some of them are implemented in Fresh version of ASMEDIT and are absolutely necessary for using ASMEDIT with Fresh:

5. Handling of modify status. AFAIK, now modified status in FASMW is handled during EM_CANUNDO - isn't it better to make AEM_SETMODIFIED/AEM_GETMODIFIED thus making possible to have undo after save. Also, if the user want to modify the text without saving the undo information it still should be able to set text as "modified".

5. What about ES_READONLY handling?

6. Also word wrap can be very usefull

7. AEM_SETUSERDATA/AEM_GETUSERDATA (linenumber, 0) is my dream.
8. AEM_GETCARETXY - returns pixel position of the caret relative to the client area of the asmedit - needed for opening code completition window on the position of the caret.

Regards.

Couldn't it be done by just using SetWindowLong / GetWindowLong ?