ARRPOS DB 20 DUP (0)
ARRCOUNT DW 0
    

PRINT_AH:
        PUSHA
        ... move the code lines for printing AH here ...
        POPA
        RET
    

...
MOV AX, 4C00h
INT 21h

<-- INSERT THE CODE FOR "PRINT_AH" FUNCTION HERE !

STRING DB ...
... etc. data declared
    

;
; Preserve registers we going to use
;
PUSH DI
PUSH AX
;
; POS = SI minus address of STRING
;
MOV AX, SI
SUB AX, OFFSET STRING
;
; Store AL into ARRPOS [ARRCOUNT]
;
MOV DI, OFFSET ARRPOS
ADD DI, ARRCOUNT
MOV [DI], AL
INC ARRCOUNT
;
; Restore used registers (they may be needed later in code)
;
POP AX
POP DI
    

MOV CX, ARRCOUNT
MOV SI, ARRPOS

PRINT_POS:

CMP CX, ARRCOUNT
JE DO_PRINT_POS

MOV DX, ", "   ; <-- declare it and use the name
MOV AH, 9
INT 21H

DO_PRINT_POS:
MOV AH, [SI]
INC SI
CALL PRINT_AH
LOOP PRINT_POS

; print 10,13,"$"
    

Count the number of a particular character in a string

; Usage : 
; E(SI) - Pointer to string
; BL - Character
; OUT: E(CX) number of characters
count_num_of_chars_in_string:
; save registers
pushfd ; save flags will be altered by cmp 
push eax
push esi
xor ECX, ECX ; make ECX 0
.loop:
lodsb
cmp al, bl
je .found_char
cmp al, 0
je .done
jmp .loop
.found_char:
inc ECX
jmp .loop
.done:
pop esi
pop eax
popfd
ret

    

.loop:
  loop .loop
    

Then you need an array of positions and a counter of how many stored:

Code:

ARRPOS DB 20 DUP (0)
ARRCOUNT DW 0
    

Next you need to make the code which prints AH into a function:

Code:

PRINT_AH:
        PUSHA
        ... move the code lines for printing AH here ...
        POPA
        RET
    

Insert that whole code after exiting to DOS, but before the data is declared:

Code:

...
MOV AX, 4C00h
INT 21h

<-- INSERT THE CODE FOR "PRINT_AH" FUNCTION HERE !

STRING DB ...
... etc. data declared
    

Now, when the character is found -- you count it, so immedeately after that you need to calculate and store
the position into that array:

Code:

;
; Preserve registers we going to use
;
PUSH DI
PUSH AX
;
; POS = SI minus address of STRING
;
MOV AX, SI
SUB AX, OFFSET STRING
;
; Store AL into ARRPOS [ARRCOUNT]
;
MOV DI, OFFSET ARRPOS
ADD DI, ARRCOUNT
MOV [DI], AL
INC ARRCOUNT
;
; Restore used registers (they may be needed later in code)
;
POP AX
POP DI
    

It is possible that this code ^^^ is also nice to put into a function to make your code easier to read.

After the process, you just need to print all values from ARRPOS array:

Code:

MOV CX, ARRCOUNT
MOV SI, ARRPOS

PRINT_POS:

CMP CX, ARRCOUNT
JE DO_PRINT_POS

MOV DX, ", "   ; <-- declare it and use the name
MOV AH, 9
INT 21H

DO_PRINT_POS:
MOV AH, [SI]
INC SI
CALL PRINT_AH
LOOP PRINT_POS

; print 10,13,"$"
    

MOV SI, ARRPOS    

Oh... right, in MASM you use OFFSET in front of the name. Just use OFFSET ARRPOS.

I have FASM, and you use MASM.
I can try however...

Actually, I'll help anyone, female or not.
Please take a look at the code:

AsmGuru62 wrote:

I have FASM, and you use MASM.
I can try however...

thanks a lot!

It is really funny how strongly impacts a female nickname in an assembly programmers forum...
Here we have even a "photo" of MariaSM, but the stack overflow users are not so naive.

A coder who uses code label ".loop:" must be punished!

Code:

.loop:
  loop .loop
    

It is really funny how strongly impacts a female nickname in an assembly programmers forum...
Here we have even a "photo" of MariaSM, but the stack overflow users are not so naive.

Perhaps it doesn't matter if the photo is real or not. Just the idea seems to be enough to elicit more positive responses. Maybe you should change your name to JaneFound and get more help with Fresh? And maybe I should change my name to SexyNerdyChick and post a picture of Natalie Portman?

Actually, I'll help anyone, female or not.
Please take a look at the code:

count:
times dd 0
...
countChars:
;esi = input asciiZ string
.loop:
    movzx eax,byte[esi]
    or al,al
    je .end:
    inc dword[counts+eax*4]
    inc esi
    jmp .loop
.end:
    ret
...
getCount:
;al = ascii code to count
;return eax = count    
    movzx eax,al
    mov eax,[counts+eax*4]
    ret
...
    

AsmGuru62 wrote:

Actually, I'll help anyone, female or not.
Please take a look at the code:

thank you very much! I really appreciate what you did for me!

this program have some bugs..after displaying the correct positions, it displays many other numbers..