flat assembler
Message board for the users of flat assembler.
Index
> IDE Development > [FASMW] Small bug inside the gui version |
Author |
|
AsmGuru62 19 Aug 2011, 01:10
Very ambitious! I like that!
|
|||
19 Aug 2011, 01:10 |
|
rohagymeg 19 Aug 2011, 02:37
In the meantime I found another bug! The built-in calculator behaves unexpectedly!
There are so many usability problems with it that I can't count them. For example you can't convert a hex value that starts with a letter like F or what's the point of the switches and the evaluate button?. I think it should be coded neatly or removed from the program because what's the point of a buggy converter if you have a perfectly working one already(calc.exe)? My second headshot EDIT: Oh, now I know where to report bugs next time. Last edited by rohagymeg on 19 Aug 2011, 02:44; edited 1 time in total |
|||
19 Aug 2011, 02:37 |
|
DOS386 19 Aug 2011, 02:42
rohagymeg wrote: For example you can't convert a hex value that starts with a letter like F or what's the point of NOT a BUG : Prefix it with a "$" : "FFFF" -> "$FFFF" Quote: it should be coded neatly or removed from the program because what's the point of a buggy converter if you have a perfectly working one already(calc.exe)? NO. 1. FASM calculator works very well 2. "calc.exe" from Windaube is shitty and doesn't exist in DOS _________________ Bug Nr.: 12345 Title: Hello World program compiles to 100 KB !!! Status: Closed: NOT a Bug |
|||
19 Aug 2011, 02:42 |
|
rohagymeg 19 Aug 2011, 02:49
Did you close this case as not a bug or is it just your signature? What about my first post? Next time I will write every problem in a separate thread.
EDIT: Yeah, not a bug, but a workaround. It's not much better! |
|||
19 Aug 2011, 02:49 |
|
Madis731 19 Aug 2011, 06:03
Most of the bugs you discovered are cosmetic ones and not very likely to cause any serious damage to an end user.
You are right on point that any feature that is there must prove to be useful. The point of the IDE calculator is not to replace calc.exe, but to provide you the tool that behaves *exactly* like FASM, including the 0x, $ prefixes and h suffix. It is not a HEX2DEC converter, but an evaluator. Try this for example: ((1234567890*234567890) SHL 2) * 7 |
|||
19 Aug 2011, 06:03 |
|
rohagymeg 19 Aug 2011, 07:16
Madis731 wrote: Most of the bugs you discovered are cosmetic ones and not very likely to cause any serious damage to an end user. I accept your view but the fact that writing D6fCh in the field does nothing even though i put an h sign at the end defeats the purpose of prefix and suffix. Fasm is famous because you can freely use most of the conventional pre/suffixes. But the calculator has this small but odd behaviour. And I didn't even search for bugs, I was just using the program normally! If it is a problem to point out all the cosmetic errors a person finds in a software then why have a gui? I mean if people don't need a reliable user interface why do they need UI at all? Command line all the way! |
|||
19 Aug 2011, 07:16 |
|
DOS386 19 Aug 2011, 07:34
rohagymeg wrote: I accept your view but the fact that writing D6fCh in the field does nothing even though i put an h sign at the end defeats the purpose of prefix and suffix. Fasm is famous because you can freely use most of the conventional pre/suffixes. But the calculator has this small but odd behaviour. Your D6fCh-vs-0D6fCh-issue is NOT a problem specific to FASM and even less to its calculator, it's just bad behavior cloned from MA$M. So please blame M$, or just use "$D6FC" and ignore the residual MA$M support in FASM Quote: And I didn't even search for bugs, I was just using the program normally! Quote: if people don't need a reliable user interface why do they need UI at all? Command line all the way! Quote: Did you close this case as not a bug? What about my first post? I didn't close anything. I just moved it where it belongs to. Also I sticked it ASS'uming your "bug" report would be valid. Maybe someone unsticks it occasionally Correct way: Code: mov eax, ($8000+99+(beef-aaac)*3+$ff) ; Constant (< 64 KiB) ... ... aaac: db "AAC", 0 ; Advanced Audio Cooling beef: db "BEEF", 0 ; From cows ... Your "superior" way: Code: mov eax, (8000+99+(beef-aaac)*3+ff) ; Constant (< 64 KiB) ... ... aaac: db "AAC", 0 ; Advanced Audio Cooling beef: db "BEEF", 0 ; From cows ... Now please reveal how FASM has to find out that "8000" and "FF" are HEX, "99" is DEC, and "beef" and "aaac" are labels. WtF ??? Last edited by DOS386 on 19 Aug 2011, 07:48; edited 6 times in total |
|||
19 Aug 2011, 07:34 |
|
revolution 19 Aug 2011, 07:36
D6fCh evaluates as a label or literal name because it starts with a non-numeric character. This is also how the assembler will evaluate it. And it was deliberately designed this way. If you wanted a hex number then you have to follow the same rules as the assembler and start with a numeric character, 0D6fCh or 0xD6fC, or as DOS386 mentions the $ also works $D6fC.
Code: D6fCh: dd 0D6fCh ;label is D6fCh, value is 0D6fCh |
|||
19 Aug 2011, 07:36 |
|
rohagymeg 19 Aug 2011, 08:18
Thank you all for the clarifications. At least I learnt something
And this thread should be unstickied. It's not so important to be stickied. It's just a "cosmetic bug". And it's easy to fix. And I'm sorry that I made it off topic. Will never happen again |
|||
19 Aug 2011, 08:18 |
|
revolution 19 Aug 2011, 09:41
I don't want to unsticky it just yet. The first post still shows a bug, and your fix for it. Once Tomasz has updated and fixed it then it can be unstickied.
|
|||
19 Aug 2011, 09:41 |
|
bitshifter 20 Aug 2011, 02:21
I peek at source and find GetSaveFileName missing param.
Code: save_file_as: invoke SendMessage,[hwnd_tabctrl],TCM_GETCURSEL,0,0 mov ebx,eax mov [ei.header.mask],TCIF_PARAM invoke SendMessage,[hwnd_tabctrl],TCM_GETITEM,ebx,ei mov eax,[ei.pszpath] or eax,eax jnz alloc_ok invoke VirtualAlloc,0,1000h,MEM_COMMIT,PAGE_READWRITE mov [ei.pszpath],eax alloc_ok: mov [lparam],eax mov [ofn.lpstrFile],eax mov [ofn.lpstrFilter],asm_filter mov [ofn.Flags],OFN_EXPLORER+OFN_HIDEREADONLY+OFN_OVERWRITEPROMPT mov [ofn.lpstrTitle],NULL ;<<<<<<<<<<<<<<<<<<<<<<<<<<<< invoke GetSaveFileName,ofn I think this is what you speak of? Next time post snippet for us to eat. _________________ Coding a 3D game engine with fasm is like trying to eat an elephant, you just have to keep focused and take it one 'byte' at a time. |
|||
20 Aug 2011, 02:21 |
|
Tomasz Grysztar 20 Aug 2011, 07:51
Yes, this is GetSaveFileName missing set-up for one parameter and that's how this should be fixed.
|
|||
20 Aug 2011, 07:51 |
|
revolution 20 Aug 2011, 15:48
A new version of 1.69.32 has been uploaded.
|
|||
20 Aug 2011, 15:48 |
|
DOS386 21 Aug 2011, 02:17
> this should be fixed.
Could you look into the open DOS IDE problems too please ? > A new version of 1.69.32 has been uploaded. Many silent updates of this 1.69.32 so far |
|||
21 Aug 2011, 02:17 |
|
rohagymeg 25 Aug 2011, 01:46
DOS386 wrote: > this should be fixed. Not true, but it's not obvious because it's not written anywhere, except in the about menu item. The ide has a separate version number, and the version I wrote + 1 number is the corrected one |
|||
25 Aug 2011, 01:46 |
|
< Last Thread | Next Thread > |
Forum Rules:
|
Copyright © 1999-2024, Tomasz Grysztar. Also on GitHub, YouTube.
Website powered by rwasa.