flat assembler
Message board for the users of flat assembler.

Index > IDE Development > [solved] FASMW backspaces

Author
Thread Post new topic Reply to topic
sinsi



Joined: 10 Aug 2007
Posts: 713
Location: Adelaide
sinsi
One backspace good, two or more bad...


Description:
Filesize: 13.25 KB
Viewed: 6568 Time(s)

Untitled.jpg


Post 30 Jul 2011, 08:10
View user's profile Send private message Reply with quote
revolution
When all else fails, read the source


Joined: 24 Aug 2004
Posts: 17715
Location: In your JS exploiting you and your system
revolution
edit: solved in latest download.


Last edited by revolution on 30 Jul 2011, 08:26; edited 1 time in total
Post 30 Jul 2011, 08:13
View user's profile Send private message Visit poster's website Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji

no problem for me (??)
sinsi, upload your file.

_________________
I am not young enough to know everything (Oscar Wilde)- Image
Post 30 Jul 2011, 08:19
View user's profile Send private message Send e-mail Reply with quote
revolution
When all else fails, read the source


Joined: 24 Aug 2004
Posts: 17715
Location: In your JS exploiting you and your system
revolution
I opened a new instance. Typed "1234567890", then BKSP-BKSP-...
Post 30 Jul 2011, 08:20
View user's profile Send private message Visit poster's website Reply with quote
revolution
When all else fails, read the source


Joined: 24 Aug 2004
Posts: 17715
Location: In your JS exploiting you and your system
revolution
It seems the very latest version (unannounced!) fixes this problem. No version number change though Sad

Tomasz, how about a fourth digit (or something) to indicate which version of IDE is currently available for download?
Post 30 Jul 2011, 08:25
View user's profile Send private message Visit poster's website Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji

"1234567890", then BKSP-BKSP-... ok

i confirm, everything behaves normally,
no problem for me (1.69.32)

EDIT:
Quote:
Tomasz, how about a fourth digit (or something) to indicate which version of IDE is currently available for download?
+1


_________________
I am not young enough to know everything (Oscar Wilde)- Image
Post 30 Jul 2011, 08:29
View user's profile Send private message Send e-mail Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji
Quote:

- It seems the very latest version (unannounced!) fixes this problem

- edit: solved in latest download


that said, i tried with old fasmw 1.69.14 ... no problem for me (i don't understand)

_________________
I am not young enough to know everything (Oscar Wilde)- Image
Post 30 Jul 2011, 08:37
View user's profile Send private message Send e-mail Reply with quote
revolution
When all else fails, read the source


Joined: 24 Aug 2004
Posts: 17715
Location: In your JS exploiting you and your system
revolution
It seems to affect only the first upload of 0.95.09 (on or around 27-Jul-2011). The current upload of 0.95.09 (28-Jul-2011) does not show the problem.
Post 30 Jul 2011, 08:41
View user's profile Send private message Visit poster's website Reply with quote
revolution
When all else fails, read the source


Joined: 24 Aug 2004
Posts: 17715
Location: In your JS exploiting you and your system
revolution
Here is a log of the changes between the two files:
Code:
Comparing files FASMW.ASM and FASMW-27-Jul-2011.ASM
***** FASMW.ASM
        jz      failed
        cmp     [ei.pszpath],NULL
        je      failed
        invoke  SendMessage,[ei.hwnd],WM_GETTEXTLENGTH,0,0
***** FASMW-27-Jul-2011.ASM
        jz      failed
        invoke  SendMessage,[ei.hwnd],WM_GETTEXTLENGTH,0,0
*****

***** FASMW.ASM
        mov     [lparam],eax
        invoke  CreateFile,[ei.pszpath],GENERIC_WRITE,0,0,CREATE_ALWAYS,0,0
        cmp     eax,-1
        je      save_failed
        mov     ebx,eax
***** FASMW-27-Jul-2011.ASM
        mov     [lparam],eax
        mov     eax,[ei.pszpath]
        or      eax,eax
        jz      failed
        invoke  CreateFile,eax,GENERIC_WRITE,0,0,CREATE_ALWAYS,0,0
        cmp     eax,-1
        je      failed
        mov     ebx,eax
*****

***** FASMW.ASM
        jmp     finish
      save_failed:
        invoke  VirtualFree,[lparam],0,MEM_RELEASE
        jmp     failed
  fmcompile:
***** FASMW-27-Jul-2011.ASM
        jmp     finish
  fmcompile:
*****

***** FASMW.ASM
        invoke  EndDialog,[hwnd_dlg],TRUE
        jmp     .finish
  .close:
***** FASMW-27-Jul-2011.ASM
        invoke  EndDialog,[hwnd_dlg],TRUE
        jmp     finish
  .close:
*****    
Post 30 Jul 2011, 08:47
View user's profile Send private message Visit poster's website Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji

no, the problem was here!
Code:
no_selection_to_clear:

        .....

        mov     [current_operation],VK_BACK
        cmp     [last_operation],VK_BACK

 jne     backspace_undopoint ;<-- now (before: je character_undo_ok)

      mov     eax,[unmodified_state]
      cmp     eax,[undo_data]
     jne     undo_backspace_ok
   xor     eax,eax
     mov     [unmodified_state],eax
      jmp     undo_backspace_ok
backspace_undopoint:
       call    make_undopoint
undo_backspace_ok:
    

_________________
I am not young enough to know everything (Oscar Wilde)- Image


Last edited by ouadji on 30 Jul 2011, 09:00; edited 2 times in total
Post 30 Jul 2011, 08:58
View user's profile Send private message Send e-mail Reply with quote
sinsi



Joined: 10 Aug 2007
Posts: 713
Location: Adelaide
sinsi
All OK with the new download, thanks fellas.
I downloaded the 27/7 version originally.

Extra version info, yes please.
Post 30 Jul 2011, 08:58
View user's profile Send private message Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji
Image

Tomasz,

The "stealth" updates are not a good thing.
A version number must identify one and only one version,
and for now this is not the case!
This is problematic for us ... the users.
I spend my time comparing the files with UltraCompare
with always the fear of missing something.
Is there not a way to permanently solve this problem ?

Thank you Tomasz.

_________________
I am not young enough to know everything (Oscar Wilde)- Image


Last edited by ouadji on 30 Jul 2011, 09:48; edited 1 time in total
Post 30 Jul 2011, 09:37
View user's profile Send private message Send e-mail Reply with quote
MHajduk



Joined: 30 Mar 2006
Posts: 6038
Location: Poland
MHajduk
ouadji wrote:
Image

Tomasz,

The "stealth" updates are not a good thing. (...)
This is problematic for us ... the users.
What about a simple RSS?
Post 30 Jul 2011, 09:48
View user's profile Send private message Visit poster's website Reply with quote
Tomasz Grysztar



Joined: 16 Jun 2003
Posts: 7802
Location: Kraków, Poland
Tomasz Grysztar
MHajduk wrote:
What about a simple RSS?
This site provides Atom feed for that purpose.
Post 30 Jul 2011, 15:21
View user's profile Send private message Visit poster's website Reply with quote
MHajduk



Joined: 30 Mar 2006
Posts: 6038
Location: Poland
MHajduk
Tomasz Grysztar wrote:
MHajduk wrote:
What about a simple RSS?
This site provides Atom feed for that purpose.
Good to know about it. Smile I think that people involved in FASM (or FASM forks) development would be glad. Wink
Post 30 Jul 2011, 15:30
View user's profile Send private message Visit poster's website Reply with quote
Display posts from previous:
Post new topic Reply to topic

Jump to:  


< Last Thread | Next Thread >
Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Copyright © 1999-2020, Tomasz Grysztar. Also on GitHub, YouTube, Twitter.

Website powered by rwasa.