flat assembler
Message board for the users of flat assembler.

Index > Linux > Few bad line endings in libc/system.inc and linux/system.inc

Author
Thread Post new topic Reply to topic
MCD



Joined: 21 Aug 2004
Posts: 604
Location: Germany
MCD
I'm just dropping by to say that there are a few fasm source files that have bad line endings, at least for Unices: Some 0Dh,0Ah sequences should be replaced by 0Ah at the end of some message strings.

_________________
MCD - the inevitable return of the Mad Computer Doggy

-||__/
.|+-~
.|| ||
Post 11 Jun 2011, 13:24
View user's profile Send private message Reply with quote
JohnFound



Joined: 16 Jun 2003
Posts: 3502
Location: Bulgaria
JohnFound
I don't know what Unices means, but FASM supports properly all variants: $0d; $0a; $0d0a and $0a0d, so the problem is not in FASM.
Post 13 Jun 2011, 07:27
View user's profile Send private message Visit poster's website ICQ Number Reply with quote
revolution
When all else fails, read the source


Joined: 24 Aug 2004
Posts: 17663
Location: In your JS exploiting you and your system
revolution
JohnFound wrote:
I don't know what Unices means, ...
One presumes: 1 Unix, 2 Unices.

1 Matrix, 2 Matrices
1 Vertex, 2 Vertices
1 Dominatrix, 2 Dominatrices

Or in reverse:
2 Polices, 1 Polix
Post 13 Jun 2011, 07:37
View user's profile Send private message Visit poster's website Reply with quote
LocoDelAssembly
Your code has a bug


Joined: 06 May 2005
Posts: 4633
Location: Argentina
LocoDelAssembly
Unices=Unix-like OSes (e.g. Linux, FreeBSD, Solaris, etc.)

Although 0ah endings would be desirable for line sources to don't have troubles with some Unices text editors, it is not really mandatory. About the message strings, fixing that is a must, you should consider collecting all the instances you found and create a new thread in Compiler Internals.
Post 13 Jun 2011, 07:39
View user's profile Send private message Reply with quote
JohnFound



Joined: 16 Jun 2003
Posts: 3502
Location: Bulgaria
JohnFound
Ah, sorry for my illiteracy... Embarassed
Post 13 Jun 2011, 08:47
View user's profile Send private message Visit poster's website ICQ Number Reply with quote
Display posts from previous:
Post new topic Reply to topic

Jump to:  


< Last Thread | Next Thread >
Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Copyright © 1999-2020, Tomasz Grysztar. Also on GitHub, YouTube, Twitter.

Website powered by rwasa.