flat assembler
Message board for the users of flat assembler.

Index > IDE Development > [FIXED] fasmw crash with shift+downArrow

Author
Thread Post new topic Reply to topic
idle



Joined: 06 Jan 2011
Posts: 359
Location: Ukraine
idle
applies fasm and wink
Code:
row #1:
row #2: select row #2, copy it to clipboard, select row #1, paste the clipboard---------------------------------------------------------------------------------------------------------------------------------------------------------------241
row #3:
    
Post 31 Jan 2011, 06:34
View user's profile Send private message Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji

I select row 2 and I copy it into the clipboard.
After that; as you ask, I selected row 1 and then I paste the clipboard.
Here is the result,
Code:
row #2: select row #2, copy it to clipboard, select row #1, paste the clipboard---------------------------------------------------------------------------------------------------------------------------------------------------------------241
row #2: select row #2, copy it to clipboard, select row #1, paste the clipboard---------------------------------------------------------------------------------------------------------------------------------------------------------------241
row #3:    

I tired with original Fasm, and with Wink ... no problem.

_________________
I am not young enough to know everything (Oscar Wilde)- Image
Post 31 Jan 2011, 10:30
View user's profile Send private message Send e-mail Reply with quote
idle



Joined: 06 Jan 2011
Posts: 359
Location: Ukraine
idle
try selecting with Shift+ArrowDown
hi :)
Post 31 Jan 2011, 10:33
View user's profile Send private message Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji
yes !

with "Shift+ArrowDown" ... original FASM (1.69.29 - 0.95.05) crashes.
(and then Wink too ... normal !)

_________________
I am not young enough to know everything (Oscar Wilde)- Image
Post 31 Jan 2011, 10:37
View user's profile Send private message Send e-mail Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji

copy/paste (with Shift+ArrowDown) ---> crash (IDE 0.95.05)

Code:
UNDO.INC
---------
store_segment_for_undo:
  .....
       .....
       call    allocate_segment
    pop     edi
 mov     ebx,eax
     stosd
       mov     eax,[esp+4]
 stosd
       jc      memory_shortage
     mov     esi,eax
     mov     edi,ebx
     mov     ecx,SEGMENT_LENGTH shr 2

        rep     movsd ;<------------------------------------- here

    segment_for_undo_done:
 popa
    store_segment_for_undo_ok:
  retn
    

_________________
I am not young enough to know everything (Oscar Wilde)- Image


Last edited by ouadji on 31 Jan 2011, 11:45; edited 2 times in total
Post 31 Jan 2011, 11:07
View user's profile Send private message Send e-mail Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji

rep movsd

---> the problem comes from ESI. (EDI, ECX ok)

ESI = 93010000h .. and it should be 00930100h !!

(i saw this just now with syser)

_________________
I am not young enough to know everything (Oscar Wilde)- Image
Post 31 Jan 2011, 11:42
View user's profile Send private message Send e-mail Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji

Here is the problem ... and the solution Razz

all is ok now.

(Tomasz ? a little fix for this please)
Code:
BLOCKS.INC
----------
    middle_lines_removed:
      call    store_segment_for_undo
      mov     eax,esi
     or      eax,1
       mov     [edi],eax
   mov     eax,edi
     or      eax,1
       mov     [esi+4],eax
 call    cancel_line
 add     ecx,[selection_position]
    sub     ecx,[caret_position]
        call    delete_from_line
    mov     esi,[caret_line]
    call    check_line_length
   mov     esi,[esi]
   or      esi,esi
     jz      block_deleted

   btr     esi,0   ;<--- + --------------- missing instruction

  call    store_segment_for_undo
      mov     eax,[caret_line]
    mov     [esi+4],eax
    block_deleted:
    

_________________
I am not young enough to know everything (Oscar Wilde)- Image
Post 01 Feb 2011, 01:03
View user's profile Send private message Send e-mail Reply with quote
Tomasz Grysztar



Joined: 16 Jun 2003
Posts: 7725
Location: Kraków, Poland
Tomasz Grysztar
I'm uploading the fix now.

ouadji, I really thank you for your help!
Post 01 Feb 2011, 09:50
View user's profile Send private message Visit poster's website Reply with quote
ouadji



Joined: 24 Dec 2008
Posts: 1081
Location: Belgium
ouadji

with pleasure ! Wink

_________________
I am not young enough to know everything (Oscar Wilde)- Image
Post 01 Feb 2011, 10:32
View user's profile Send private message Send e-mail Reply with quote
Display posts from previous:
Post new topic Reply to topic

Jump to:  


< Last Thread | Next Thread >
Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Copyright © 1999-2020, Tomasz Grysztar. Also on YouTube, Twitter.

Website powered by rwasa.