[FIXED] fasmw crash with shift+downArrow

Index > IDE Development > [FIXED] fasmw crash with shift+downArrow

Author

Thread

idle

Joined: 06 Jan 2011
Posts: 440
Location: Ukraine

idle 31 Jan 2011, 06:34

applies fasm and wink

Code:

row #1:
row #2: select row #2, copy it to clipboard, select row #1, paste the clipboard---------------------------------------------------------------------------------------------------------------------------------------------------------------241
row #3:

31 Jan 2011, 06:34

ouadji

Joined: 24 Dec 2008
Posts: 1081
Location: Belgium

ouadji 31 Jan 2011, 10:30

I select row 2 and I copy it into the clipboard.
After that; as you ask, I selected row 1 and then I paste the clipboard.
Here is the result,

Code:

row #2: select row #2, copy it to clipboard, select row #1, paste the clipboard---------------------------------------------------------------------------------------------------------------------------------------------------------------241
row #2: select row #2, copy it to clipboard, select row #1, paste the clipboard---------------------------------------------------------------------------------------------------------------------------------------------------------------241
row #3:

I tired with original Fasm, and with Wink ... no problem.

_________________
I am not young enough to know everything (Oscar Wilde)-

31 Jan 2011, 10:30

idle

Joined: 06 Jan 2011
Posts: 440
Location: Ukraine

idle 31 Jan 2011, 10:33

try selecting with Shift+ArrowDown
hi :)

31 Jan 2011, 10:33

ouadji

Joined: 24 Dec 2008
Posts: 1081
Location: Belgium

ouadji 31 Jan 2011, 10:37

yes !

with "Shift+ArrowDown" ... original FASM (1.69.29 - 0.95.05) crashes.
(and then Wink too ... normal !)

_________________
I am not young enough to know everything (Oscar Wilde)-

31 Jan 2011, 10:37

ouadji

Joined: 24 Dec 2008
Posts: 1081
Location: Belgium

ouadji 31 Jan 2011, 11:07

copy/paste (with Shift+ArrowDown) ---> crash (IDE 0.95.05)

Code:

UNDO.INC
---------
store_segment_for_undo:
  .....
       .....
       call    allocate_segment
    pop     edi
 mov     ebx,eax
     stosd
       mov     eax,[esp+4]
 stosd
       jc      memory_shortage
     mov     esi,eax
     mov     edi,ebx
     mov     ecx,SEGMENT_LENGTH shr 2

        rep     movsd ;<------------------------------------- here

    segment_for_undo_done:
 popa
    store_segment_for_undo_ok:
  retn

_________________
I am not young enough to know everything (Oscar Wilde)-

Last edited by ouadji on 31 Jan 2011, 11:45; edited 2 times in total

31 Jan 2011, 11:07

ouadji

Joined: 24 Dec 2008
Posts: 1081
Location: Belgium

ouadji 31 Jan 2011, 11:42

rep movsd

---> the problem comes from ESI. (EDI, ECX ok)

ESI = 93010000h .. and it should be 00930100h !!

(i saw this just now with syser)

_________________
I am not young enough to know everything (Oscar Wilde)-

31 Jan 2011, 11:42

ouadji

Joined: 24 Dec 2008
Posts: 1081
Location: Belgium

ouadji 01 Feb 2011, 01:03

Here is the problem ... and the solution Razz

all is ok now.

(Tomasz ? a little fix for this please)

Code:

BLOCKS.INC
----------
    middle_lines_removed:
      call    store_segment_for_undo
      mov     eax,esi
     or      eax,1
       mov     [edi],eax
   mov     eax,edi
     or      eax,1
       mov     [esi+4],eax
 call    cancel_line
 add     ecx,[selection_position]
    sub     ecx,[caret_position]
        call    delete_from_line
    mov     esi,[caret_line]
    call    check_line_length
   mov     esi,[esi]
   or      esi,esi
     jz      block_deleted

   btr     esi,0   ;<--- + --------------- missing instruction

  call    store_segment_for_undo
      mov     eax,[caret_line]
    mov     [esi+4],eax
    block_deleted:

_________________
I am not young enough to know everything (Oscar Wilde)-

01 Feb 2011, 01:03

Tomasz Grysztar

Joined: 16 Jun 2003
Posts: 8351
Location: Kraków, Poland

Tomasz Grysztar 01 Feb 2011, 09:50

I'm uploading the fix now.

ouadji, I really thank you for your help!

01 Feb 2011, 09:50

ouadji

Joined: 24 Dec 2008
Posts: 1081
Location: Belgium

ouadji 01 Feb 2011, 10:32

with pleasure ! Wink

_________________
I am not young enough to know everything (Oscar Wilde)-

01 Feb 2011, 10:32

< Last Thread | Next Thread >

Forum Rules:

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum