Index
> Compiler Internals > Remove Comments Before Concatenation |
| Author |
|
|
pelaillo 11 Mar 2004, 02:53
please see the second post here and the answer from Privalov... http://board.flatassembler.net/topic.php?p=3696&highlight=#3696
|
|||
11 Mar 2004, 02:53 |
|
|
comrade 11 Mar 2004, 03:02
He thinks strangely...
|
|||
|
11 Mar 2004, 03:02 |
|
|
JohnFound 15 Mar 2004, 10:33
comrade wrote: He thinks strangely... He is absolutely right here. You have to meditate a little on this subject, like me, to understand the matter. 
Regards. |
|||
|
15 Mar 2004, 10:33 |
|
|
pelaillo 15 Mar 2004, 12:43
Sorry, I don't agree at all.
Both reasons are logic and good. It depends only in the sequence of operations. If preprocessor does the concatenation before, then the consequence is that Privalov´s way is the better. But if preprocessor cut out the comments before (imho is the first thing a preprocessor must do in a compiler) the logic employed by us is right. But the matter is different. We are asking for a feature here. It is more comfortable to have comments stripped before. I have given some examples, and here is another: Code: CSTR_TABLE html_reserved_words,\ <1,'a'>,\ \; <1,'b'>,\ \; <1,'i'>,\ <1,'p'>,\ \; <1,'q'>,\ \; <1,'s'>,\ \; <1,'u'>,\ <2,'br'>,\ \; <2,'dd'>,\ \; <2,'dl'>,\ \; <2,'dt'>,\ \; <2,'em'>,\ \; <8,'noscript'>,\ \; <8,'optgroup'>,\ \; <8,'textarea'>,\ <10,'blockquote'> |
|||
|
15 Mar 2004, 12:43 |
|
|
Tomasz Grysztar 15 Mar 2004, 13:29
No matter if you strip the comments before or later, there is always the beginning of line (the "white space" before the semicolon) that is not a part of comment - and this empty space is seen by the preprocessor as a contents of the line and is used for concatenation.
|
|||
|
15 Mar 2004, 13:29 |
|
|
JohnFound 15 Mar 2004, 14:53
pelaillo wrote: Sorry, I don't agree at all. Well, I am totally confused, who assert what... 
To clear the things: I think that FASM in it's present variant concatenates lines absolutely right. It do not need any imrovement in this point. 
Regards. |
|||
|
15 Mar 2004, 14:53 |
|
|
pelaillo 15 Mar 2004, 15:06
This was a "feature request" not a "bug report"
And I have seen your point, I have considered it and still prefer the other way arround. An only-comment-line is a nonexistent line at all. Preporcessor is able to identify them without getting tricky and without loosing logic. I am only saying that is a feature that you win during code writing, editors let you to (un)comment bunch of lines and your code gains in readability. Comments live only in programmers realm. They are not used at all in further steps of compiling process. I want to contribute, not to disturb. Sorry for the incomprehension but english is not my language. |
|||
|
15 Mar 2004, 15:06 |
|
|
Tomasz Grysztar 15 Mar 2004, 15:32
pelaillo wrote: An only-comment-line is a nonexistent line at all. Not in fasm's architecture. It's an empty line, the same as the one you achieve with just putting one CR-LF after another. |
|||
|
15 Mar 2004, 15:32 |
|
|
vid 15 Mar 2004, 20:11
privalov is right. keep it as is, it's allright
|
|||
|
15 Mar 2004, 20:11 |
|
< Last Thread | Next Thread > |
Forum Rules:
|