Index
> Main > CRLF ? newline |
| Author |
|
|
vid 22 Feb 2010, 23:12
Strictly speaking, this should depend on what OS you are on
But as for FASM's purpose and design, tomasz's solution is okay. It probably wouldn't be in something else. |
|||
22 Feb 2010, 23:12 |
|
|
LocoDelAssembly 22 Feb 2010, 23:31
You might find this article interesting: http://www.codinghorror.com/blog/2010/01/the-great-newline-schism.html
|
|||
|
22 Feb 2010, 23:31 |
|
|
ouadji 22 Feb 2010, 23:40
I looked in the FASM code for windows, and even with this version, it seems to accept the 4 possibilities. Curious, no? Code: find_concatenated_line: lods byte [esi] cmp al,0Ah je concatenate_lf cmp al,0Dh je concatenate_cr ....... concatenate_lf: lods byte [esi] cmp al,0Dh je concatenate_ok <--- LF + CR ok dec esi jmp concatenate_ok <-- LF ok concatenate_cr: lods byte [esi] cmp al,0Ah je concatenate_ok <--- CR + LF ok dec esi <--- no jump, CR ok concatenate_ok: inc dword [esp] <----------- here newline ! jmp convert_line_data _________________ I am not young enough to know everything (Oscar Wilde)-  |
|||
|
22 Feb 2010, 23:40 |
|
|
revolution 22 Feb 2010, 23:41
I suggest you accept/allow all four possibilities.
No need to limit the flexibility arbitrarily. |
|||
|
22 Feb 2010, 23:41 |
|
|
ouadji 22 Feb 2010, 23:43
thank you LocoDelAssembly, very interesting article indeed _________________ I am not young enough to know everything (Oscar Wilde)- |
|||
|
22 Feb 2010, 23:43 |
|
|
ouadji 22 Feb 2010, 23:54
Quote:
ok but, there is no risk of being too much universal, too much versatile, and detect ghost newline ? _________________ I am not young enough to know everything (Oscar Wilde)- |
|||
|
22 Feb 2010, 23:54 |
|
|
revolution 23 Feb 2010, 00:14
ouadji wrote: ok but, there is no risk of being too much universal, too much versatile, and detect ghost newline ? |
|||
|
23 Feb 2010, 00:14 |
|
|
DOS386 23 Feb 2010, 04:54
vid wrote: Strictly speaking, this should depend on what OS you are on Welcome to the hell 
Quote: But as for FASM's purpose and design, tomasz's solution is okay. It probably wouldn't be in something else. You should "pirate" Tomasz's approach  |
|||
|
23 Feb 2010, 04:54 |
|
|
ouadji 23 Feb 2010, 08:14
my question is about this : clic my last version became really powerful, but I still have few small details to improve. I will use Tomasz's approach I prefer to remain fully compatible with its code. _________________ I am not young enough to know everything (Oscar Wilde)- |
|||
|
23 Feb 2010, 08:14 |
|
|
DOS386 23 Feb 2010, 08:37
> my question is about this : clic
"clic" = "suggestion /* Comments */ (Nested comments ok)" Much appreciated, I'll test |
|||
|
23 Feb 2010, 08:37 |
|
|
ouadji 23 Feb 2010, 22:05
thanks a lot to test it. If you have any questions about it, ask me. To place comments with FASM, it's very powerful. I am currently developing the next version. There are some flaws to correct. Optimize and structuring the code ... better management of "newline" and "end of file" ... and other little things to improve. But the version in my last post is already very good. I'm working, this is in preparation ... soon. Please, if you test my code, give me your comments, results and feedback. Thank you very much
_________________ I am not young enough to know everything (Oscar Wilde)- |
|||
|
23 Feb 2010, 22:05 |
|
< Last Thread | Next Thread > |
Forum Rules:
|