flat assembler
Message board for the users of flat assembler.
![]() |
Author |
|
yaros 07 Jan 2024, 20:25
So I did fix it, I think. I'm not good at x86 assembly, but I'm going to leave the patch here, just because I'm not sure how often fasmg gets released.
I'm surprised (and not, at the same time) that this was never noticed ![]() Code: *** fasmg/source/expressions_orig.inc 2023-06-22 13:55:48.000000000 -0600 --- fasmg/source/expressions.inc 2024-01-07 13:15:00.365383243 -0700 *************** *** 281,287 **** shl eax,cl or [edi],al sub ebx,1 ! jc number_converted add cl,3 cmp cl,8 jb octal_digit --- 281,287 ---- shl eax,cl or [edi],al sub ebx,1 ! jc finish_octal add cl,3 cmp cl,8 jb octal_digit *************** *** 290,295 **** --- 290,302 ---- mov [edi],ah xor eax,eax jmp octal_digit + finish_octal: + add cl,3 + cmp cl,8 + jb number_converted + inc edi + mov [edi],ah + jmp number_converted skip_octal_digit: sub ebx,1 jnc octal_digit |
|||
![]() |
|
Tomasz Grysztar 07 Jan 2024, 20:29
Confirmed, the bug was causing this very simple test to fail:
Code: assert 454o = 0454o It's fixed in kaqg. |
|||
![]() |
|
yaros 08 Jan 2024, 03:55
That was fast. Thanks!
|
|||
![]() |
|
< Last Thread | Next Thread > |
Forum Rules:
|
Copyright © 1999-2025, Tomasz Grysztar. Also on GitHub, YouTube.
Website powered by rwasa.