jochenvnltn wrote:

fasmnewbie wrote:

Try to simplify your DLLMain proc to basic initialization task only. Calling MessageBox and / or ExitProcess will call another DLLs. Replace ExiitProcess with ret. You probably need dummy fixups too.

nope.. that wasn't the problem ..

That's exactly the problem.

1) Calling ExitProcess at the start of a DLL initialization will render all other subsequent modules in your DLL inaccessible / invisible due to sudden exit of the entire DLL. Just use ret.

2) Calling other complicated modules such as MessageBox will clobber your EAX (=TRUE), which is supposed to be the return value of DLLEntryPoint/DllMain.

3) Microsoft strongly advised against calling other libraries in the DLLMain unnecessarily because they might be unsafe.

From https://msdn.microsoft.com/en-us/library/windows/desktop/dn633971(v=vs.85).aspx#general_best_practices

Things to avoid in DLLMain:

- Call LoadLibrary or LoadLibraryEx (either directly or indirectly). This can cause a deadlock or a crash.
- Call GetStringTypeA, GetStringTypeEx, or GetStringTypeW (either directly or indirectly). This can cause a deadlock or a crash.
- Synchronize with other threads. This can cause a deadlock.
- Acquire a synchronization object that is owned by code that is waiting to acquire the loader lock. This can cause a deadlock.
Initialize COM threads by using CoInitializeEx. Under certain conditions, this function can call LoadLibraryEx.
- Call the registry functions. These functions are implemented in Advapi32.dll. If Advapi32.dll is not initialized before your DLL, the DLL can access uninitialized memory and cause the process to crash.
- Call CreateProcess. Creating a process can load another DLL.
- Call ExitThread. Exiting a thread during DLL detach can cause the loader lock to be acquired again, causing a deadlock or a crash.
- Call CreateThread. Creating a thread can work if you do not synchronize with other threads, but it is risky.
- Create a named pipe or other named object (Windows 2000 only). In Windows 2000, named objects are provided by the Terminal Services DLL. If this DLL is not initialized, calls to the DLL can cause the process to crash.
- Use the memory management function from the dynamic C Run-Time (CRT). If the CRT DLL is not initialized, calls to these functions can cause the process to crash.
- Call functions in User32.dll or Gdi32.dll. Some functions load another DLL, which may not be initialized.
- Use managed code.

format PE64 GUI 4.0 DLL
entry DllEntryPoint

include 'win64ax.inc'

proc DllEntryPoint hinstDLL:QWORD,fdwReason:QWORD,lpvReserved:QWORD


.if rdx = DLL_PROCESS_ATTACH; <----- (this was the reason the DLL did not work)

         invoke MessageBox,NULL,szText,szTitle,MB_OK
        .endif

endp


szText db '64Bit DLL!!',0
szTitle db 'Success',0

section '.idata' import data readable writeable
library user32,'user32.dll',kernel32,'kernel32.dll'

include 'api\kernel32.inc'
include 'api\user32.inc'

data        fixups
end         data
                   
    

But revolution is right; Microsoft themselves say it. You should not use MessageBox from a .dll's EntryPoint because if it gets loaded by an app that doesn't import user32 it will crash. The only safe functions are those in kernel32 excluding those mentioned in the list (e.g. synchronization APIs are bad).

Just because it works for you doesn't mean it's good coding practice or that it will work in the future. It's a ticking time bomb. Microsoft write specs for a reason.

Well I don't know why it didn't work ...

Well I don't know why it didn't work, but that's because I hate using those "high level" macros and prefer to just code in raw asm (I mean, since I'm doing assembly anyway). And I didn't mean to imply that it was the problem or wasn't a test -- I just thought that you ignored what he said because you thought he was speaking nonsense, based on your tone.

But if you already knew that, then you could've just said it and that it's just a test when he replied. Anyway at least you got it solved.

Also, I meant fasmnewbie, not revolution, sorry for the confusion.

Also found this
Examples for Win64 Iczelion tutorial
http://masm32.com/board/index.php?topic=4190.0
Would be nice if someone would make a FASM version & get some conversation going about 64bit ASM