given this code

Code:

dd minicube,300,3200,400         dd minicube,300,3200,400         dd minicube,300,3200,400

when i try to replace 0,400 by 0,400,Blue

only the first line will be replaced. if the first line don't end with 0,400 it will replace nothing at all...
here the gif of the problem: http://fool.codercat.org/fasmreplacebug.gif
tested with the very last version of fasm

it happens with the file uploaded, never saw this bug before.

thanks.

The problem can be more easily seen by just trying to find the following string patterns:
(always without qoutes)
"400" : no problems
",400" : finds the occurrences, but if you open the search dialog again it shows "400" (i.e. it removes the comma)
"0,400" : finds nothing.

By some quick testing, it seems that searches like x,y are converted into y the next time you open the search dialog. The "0,400" and "0,Blu" patterns fail, but "0,4", "0,40", "0,B", "0,Bl" and "0,Blue" all work.

tested with:

Code:

0,000 0,000 0,000

replace 0,000 by 0,00 OK

Code:

0,000,123 0,000,123

replace 0,123 by 0,00 OK

Code:

0,00,400 0,00,400

replace 0,400 by 0,00 OK

Code:

0,222,400 0,222,400

replace 2,400 by 0,00 OK

Code:

0,000,400 0,000,400

replace 0,400 by 0,00 notfound

Code:

0,000,100 0,000,100

replace 0,100 by 0,00 notfound

Code:

0,222,122 0,222,122

replace 2,122 by 0,00 not found

Code:

0,222,122 0,222,122 22*2,122

replace 2.122 by 0,00 Ok, one replace here->*

Code:

;CURSOR position->* 0,22*2,122 0,222,122

replace 2,122 by 0,00 replace ok, 1 replace

but what is the limit?

Quick fix: in SEARCH.INC find this section

Code:

match_part_of_suffix:         mov     eax,[esp]         push    ecx esi edi         xchg    eax,esi         sub     eax,esi         sub     ecx,eax         repe    cmpsb         pop     edi esi ecx         jne     suffix_match_shifts_table_done     store_suffix_match_shift:

and replace "sub ecx,eax" with "add ecx,eax".

I will upload the corrected package later.

thank you so much